fix(rct): handle reader conditionals#10
Merged
robertluo merged 1 commit intoMar 23, 2026
Merged
Conversation
…pectation strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
#?reader conditionals in test expectationsProblem
RCT expectations containing reader conditionals (
#?(:clj ... :cljr ...)) fail withConditional read not allowed. This affects.cljcprojects that need platform-specific expected values.There are two independent issues:
Issue 1:
default-read-expectationusesread-stringwithout:read-conddefault-read-expectationcalls(read-string expectation-string), which throws on#?.Fix:
(read-string {:read-cond :allow} expectation-string)This affects both inline (
;=> #?(:clj 1 :cljr 2)) and separate-line expectations.Issue 2: Separate-line expectations are evaluated as standalone test expressions
test-sexpr-zlocsreturns allz/sexpr-able?nodes inside a^:rct/test (comment ...)block, including forms that serve as separate-line expectations:For normal values this is harmless (
(eval 2)→ 2). But rewrite-clj'sReaderMacroNode.sexpr*converts#?(:clj x :cljr y)into the form(read-string "#?(:clj x :cljr y)"), and evaluating this callsclojure.core/read-stringwithout:read-cond :allow→ error.Fix: Filter out nodes that directly follow an empty result comment — they are expectations, not test expressions. The actual assertion still runs via
expectation-data(which traverses forward from the test expression).