Skip to content

fix: make provider rail scrollable#543

Merged
robinebers merged 1 commit into
robinebers:mainfrom
rohithgoud30:fix/all-providers-scroll
Jun 4, 2026
Merged

fix: make provider rail scrollable#543
robinebers merged 1 commit into
robinebers:mainfrom
rohithgoud30:fix/all-providers-scroll

Conversation

@rohithgoud30
Copy link
Copy Markdown
Contributor

@rohithgoud30 rohithgoud30 commented Jun 3, 2026

Description

Makes the provider icon rail scroll independently when the list is taller than the OpenUsage panel.

The fix is scoped to the left rail: Home stays fixed at the top, Help/Settings stay fixed at the bottom, and the provider icons in the middle can scroll.

Related Issue

Type of Change

  • Bug fix
  • New feature
  • New provider plugin
  • Documentation
  • Performance improvement
  • Other (describe below)

Testing

  • I ran bun run build and it succeeded
  • I ran bun run test and all tests pass
  • I tested the change locally with bun tauri dev

Screenshots

Before After
RECORDING_5.mov
RECORDING_6.mov

Checklist

  • I read CONTRIBUTING.md
  • My PR targets the main branch
  • I did not introduce new dependencies without justification

Summary by CodeRabbit

  • Bug Fixes
    • Improved the plugin icons list layout in the sidebar to be vertically scrollable within a constrained height, preventing unintended sidebar expansion when displaying multiple plugins.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b381539b-6f21-4420-be7f-73a6e3665ae2

📥 Commits

Reviewing files that changed from the base of the PR and between 908cf08 and 1c2e113.

📒 Files selected for processing (1)
  • src/components/side-nav.tsx

📝 Walkthrough

Walkthrough

SideNav adds a scrollable flex container around the draggable plugin icons area. The wrapper constrains height with min-h-0, enables vertical scrolling via overflow-y-auto, and applies scrollbar styling. Drag-and-drop rendering logic remains unchanged.

Changes

Plugin Icons Scrolling

Layer / File(s) Summary
Scrollable plugin icons wrapper
src/components/side-nav.tsx
DndContext and SortableContext are wrapped in a new scrollable flex container that constrains height, enables vertical overflow, and applies scrollbar styling while preserving the existing drag-and-drop item rendering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: make provider rail scrollable' directly describes the main change: wrapping the plugin icon list to enable vertical scrolling of the provider rail, which is the core objective of this PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@rohithgoud30 rohithgoud30 force-pushed the fix/all-providers-scroll branch from 908cf08 to 1c2e113 Compare June 3, 2026 02:43
Copy link
Copy Markdown
Owner

@robinebers robinebers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild edge case but great PR, thank you. LGTM.

@robinebers robinebers merged commit f91bcf3 into robinebers:main Jun 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants