WebRTC - python sdk #1701
Open
WebRTC - python sdk #1701
+3,039
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digaobarbosa
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
2 tasks
grzegorz-roboflow
previously approved these changes
Nov 14, 2025
inference_sdk/webrtc/client.py
Outdated
| # Workflow specification mode | ||
| return {"workflow_specification": workflow} | ||
| else: | ||
| raise ValueError( |
Collaborator
There was a problem hiding this comment.
maybe sdk-specific exceptions could be introduced?
| from aiortc import RTCDataChannel, RTCPeerConnection | ||
|
|
||
|
|
||
| def _check_webrtc_dependencies(): |
inference_sdk/webrtc/session.py
Outdated
|
|
||
|
|
||
| # Configuration constants | ||
| DEFAULT_INITIAL_FRAME_TIMEOUT = 30.0 # seconds to wait for first video frame |
Collaborator
There was a problem hiding this comment.
maybe env-configurable?
|
|
||
| source = VideoFileSource(str(test_video_path)) | ||
|
|
||
| with WebRTCSession( |
Collaborator
There was a problem hiding this comment.
I do not really see enter(...) - does it work?
| -r requirements/requirements.sdk.http.txt \ | ||
| -r requirements/requirements.test.unit.txt | ||
| - name: 🧪 E2E Tests - WebRTC SDK (real server) |
Contributor
Author
There was a problem hiding this comment.
When I was working on it, the tests felt empty without talking with the real api. Kind of not testing much.
With this, it is validating much more on terms of compability.
PawelPeczek-Roboflow
requested changes
Nov 14, 2025
Collaborator
PawelPeczek-Roboflow
left a comment
PawelPeczek-Roboflow
left a comment
There was a problem hiding this comment.
Please fix CI
Also - seems like the session object meant to be used in contextmanager lacks enter / exit
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a specific python sdk for webrtc.
The objective is to make it easy to use the inference webrtc API and consume it using python.
It has samples on how the code looks for the dev for webcam, local file, rtsp.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
locally
Any specific deployment considerations
it's a inferecen-sdk only change
Docs