Skip to content

feat: Add Husky git hook manager support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesm merged 5 commits into from
Jan 9, 2026
Merged

feat: Add Husky git hook manager support #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf33137
feat: Use full path to roborev in git hooks
sinzin91 Jan 9, 2026
8dc28e3
test: Trigger roborev with codex agent
sinzin91 Jan 9, 2026
88584e6
fix: Correct indentation on comment
sinzin91 Jan 9, 2026
4849d84
test: Verify improved hook with quoting and fallback
sinzin91 Jan 9, 2026
8532004
fix: Add shell quoting and fallback to hook generation
sinzin91 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ git commit -m "..." # Reviews happen automatically
roborev tui # View reviews in interactive UI
```

**Note**: Hook installation automatically detects your git hook manager (Husky, etc.) via `core.hooksPath`.

## Commands

| Command | Description |
Expand Down
36 changes: 30 additions & 6 deletions cmd/roborev/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,23 @@ func initCmd() *cobra.Command {
return fmt.Errorf("get hooks path: %w", err)
}
hookPath := filepath.Join(hooksDir, "post-commit")
hookContent := `#!/bin/sh

// Get full path to roborev executable to avoid PATH issues in hooks
roborevPath, err := exec.LookPath("roborev")
if err != nil {
roborevPath = "roborev" // Fallback to PATH lookup
}

// Create hook with proper quoting and fallback for moved/upgraded binaries
hookContent := fmt.Sprintf(`#!/bin/sh
# RoboRev post-commit hook - auto-reviews every commit
roborev enqueue --quiet &
`
ROBOREV=%q
if [ ! -x "$ROBOREV" ]; then
ROBOREV=$(command -v roborev) || exit 0
fi
"$ROBOREV" enqueue --quiet &
`, roborevPath)

// Ensure hooks directory exists
if err := os.MkdirAll(hooksDir, 0755); err != nil {
return fmt.Errorf("create hooks directory: %w", err)
Expand Down Expand Up @@ -739,10 +752,21 @@ func installHookCmd() *cobra.Command {
return fmt.Errorf("create hooks directory: %w", err)
}

hookContent := `#!/bin/sh
// Get full path to roborev executable to avoid PATH issues in hooks
roborevPath, err := exec.LookPath("roborev")
if err != nil {
roborevPath = "roborev" // Fallback to PATH lookup
}

// Create hook with proper quoting and fallback for moved/upgraded binaries
hookContent := fmt.Sprintf(`#!/bin/sh
# RoboRev post-commit hook - auto-reviews every commit
roborev enqueue --quiet &
`
ROBOREV=%q
if [ ! -x "$ROBOREV" ]; then
ROBOREV=$(command -v roborev) || exit 0
fi
"$ROBOREV" enqueue --quiet &
`, roborevPath)

if err := os.WriteFile(hookPath, []byte(hookContent), 0755); err != nil {
return fmt.Errorf("write hook: %w", err)
Expand Down
Loading