fix: create .git/hooks directory if it doesn't exist#6
Merged
wesm merged 1 commit intoroborev-dev:mainfrom Jan 8, 2026
Merged
Conversation
The init and install-hook commands now create the .git/hooks directory if it doesn't exist before attempting to write the post-commit hook file. This fixes the "no such file or directory" error when initializing roborev in repositories where the hooks directory has been removed or never created. Changes: - Added os.MkdirAll for hooks directory in initCmd() - Added os.MkdirAll for hooks directory in installHookCmd() - Added comprehensive test TestInitCmdCreatesHooksDirectory Fixes the issue where roborev init would fail with: Error: install hook: open .git/hooks/post-commit: no such file or directory Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
|
thank you! |
wesm
added a commit
that referenced
this pull request
Jan 8, 2026
- Use os.PathListSeparator instead of hardcoded ":" for Windows compat - Remove dead cmd = exec.Command() code that was never executed - Add TestInstallHookCmdCreatesHooksDirectory for install-hook coverage Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roborev initfails when the.git/hooksdirectory doesn't exist:This happens in repositories where the hooks directory has been removed or was never created.
Solution
Added
os.MkdirAllto create the.git/hooksdirectory before attempting to write the post-commit hook file.Changes
cmd/roborev/main.go: Added hooks directory creation in bothinitCmd()andinstallHookCmd()cmd/roborev/main_test.go: Added comprehensive testTestInitCmdCreatesHooksDirectorythat:roborev initsucceedsTesting
All existing tests pass, and the new test confirms the fix:
The fix follows TDD methodology: