Skip to content

Add Helpful Comment to CONTRIBUTING.md #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

Suave101
Copy link
Contributor

@Suave101 Suave101 commented Jan 4, 2024

In pull request #100, a comment was made to:

"add a comment about that here too."

in reference to:

"try it on your computer then just install robotpy[cscore] and opencv-python and you can run this file locally with your computer's camera via python -m cscore vision.py"

Therefore a line was added to CONTRIBUTING.md to help people test files that they are porting to RobotPy examples!

CONTRIBUTING.md Outdated
@@ -20,6 +20,7 @@ Testing:
* New examples must run! You *must* test your code on either a robot or in
simulation. If there's something broken in RobotPy, file an issue to get it
fixed
* To test a vision file, run `python -m cscore vision.py` in the directory of the vision file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:
30aef8b

@auscompgeek auscompgeek merged commit 6f6ff76 into robotpy:main Jan 5, 2024
@auscompgeek
Copy link
Member

Thanks!

@Suave101 Suave101 deleted the patch-1 branch January 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants