Frisbeebot example #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the program to be in docstring.
Co-authored-by: David Vo <[email protected]>
|
@virtuald should i add the frisbeebot example to ignored tests? It works as intended in simulation but setDistancePerPulse fails the test even though it seems like nothing has changed from 2022. |
|
Let me take a look locally. |
|
The problem is that all of your motors/encoders are initialized at the class level instead of in |
|
I'm going to go ahead and fix this locally, adjust some of the style to match python better, and push a new PR using the fixes in a few minutes. Thanks! |
Merged
|
Closed in favor of #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension of #56, as you can't change which branch you want to merge from on a ongoing pr.