Skip to content

Remove Phoenix 6 references in mostrobotpy #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daltzctr
Copy link

@daltzctr daltzctr commented Mar 6, 2025

I believe this is breaking mid-season, so probably a merge for post season. We have had several customers get bit by robotpy installing an out-of-date Phoenix 6 vendordep with critical fixes or changes that can't be traced down to a pinned dependency. This is due to the implicit pinning of versions in the robotpy_extras block.

Our recommendation is to just add the phoenix6 dependency to the

requires = [

]

block anyways. Python handles this correctly during both sync and deploy.

@virtuald
Copy link
Member

virtuald commented Mar 6, 2025

Yeah, I'd like to remove it: robotpy/robotpy-installer#118

For this season, I think it would be best to just bump the version or expand the dependency range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants