[MAIN-2976] new relic support #266
Open
+209
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Avi-Robusta
commented
Feb 4, 2025
•
Avi-Robusta
commented
nherment
reviewed
Feb 17, 2025
|
|
||
| For more details on New Relic's API and authentication methods, refer to [New Relic API documentation](https://docs.newrelic.com/docs/apis). | ||
|
|
||
| </details> |
There was a problem hiding this comment.
This should be moved to a page on robusta docs where we gathered all the toolset documentation: https://docs.robusta.dev/master/configuration/holmesgpt/builtin_toolsets.html
There was a problem hiding this comment.
Example PR: robusta-dev/robusta#1727
| """ | ||
| } | ||
|
|
||
| url = "https://api.newrelic.com/graphql" |
There was a problem hiding this comment.
Should this be overridable for people having on premise newrelic?
| super().__init__( | ||
| name="newrelic", | ||
| description="Toolset for interacting with New Relic to fetch logs and traces", | ||
| docs_url="https://docs.newrelic.com/docs/apis/nerdgraph-api/", |
There was a problem hiding this comment.
Similar comment to the above regarding docs, URL should be similar to https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/newrelic.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.