switch to iostream with big buffer #33
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhtz
reviewed
Oct 24, 2025
| FileStream fileStream; | ||
| //FileStream fileStream; | ||
| std::ifstream fileStream; | ||
| char ReadBuffer[16777216]; //16MB |
Member
There was a problem hiding this comment.
I would avoid having objects that large (potentially) on the stack.
Also, did you also try making blocksize of pocolog_cpp::FileStream configurable?
Member
|
If the access pattern is very random, it might also be interesting to try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test branch to test improvement to reading network-mounted log files