Not all negative Celsius measurements convert to a negative Fahrenheit#1
Open
kizniche wants to merge 1 commit intoroder:masterfrom
Open
Not all negative Celsius measurements convert to a negative Fahrenheit#1kizniche wants to merge 1 commit intoroder:masterfrom
kizniche wants to merge 1 commit intoroder:masterfrom
Conversation
…t (example, -5C = 23F)
|
Totally agree with kizniche : it would be nice to get this change in the master branch. @roder : Could you merge this branch ? I see there is no change since 3 years in this project but I use it and I like it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In your code, all Celsius measurements will be converted to Fahrenheit, then if negative is True, both Celsius and Fahrenheit will be set negative at the same time. However, because of the difference in scales, there are a range of measurements that are both negative in Celsius and positive in Fahrenheit.
For example, -5C = 23F
Therefore, if Celsius is negative, it should be set negative, when go through the c_to_f() conversion to Fahrenheit.