Fix: Negatives temperatures are not correctly returned.#2
Open
achataigner wants to merge 1 commit intoroder:masterfrom
Open
Fix: Negatives temperatures are not correctly returned.#2achataigner wants to merge 1 commit intoroder:masterfrom
achataigner wants to merge 1 commit intoroder:masterfrom
Conversation
Issue: When the temperature is negative, the absolute value of the real temperature is returned: If the temperature is -3°C the method temperature() still returns 3°C. The negative temperature was not correctly detected: now we test the correct bit to know if the temperature is negative or not. The same bit is checked in this repo: https://github.com/adafruit/Adafruit_AM2315 in Adafruit_AM2315.cpp: ```c // change sign if (reply[4] >> 7) temp = -temp; ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When the temperature is negative, the absolute value of the real temperature is returned:
If the temperature is -3°C the method temperature() still returns 3°C.
The negative temperature was not correctly detected: now we test the correct bit to know if the temperature is negative or not.
The same bit is checked in this repo: https://github.com/adafruit/Adafruit_AM2315 in Adafruit_AM2315.cpp: