GH-7: [Python] Fix invalid-context-manager error - #30
Merged
Merged
Conversation
The main problem was that these were annotated as instance methods rather than static/class methods, but I've added some detail, too.
Fix stubs for Table factory methods
chore: update pre-commit
fix: make fs.FileSystem.from_uri and hdfs.HadoopFileSystem.from_uri as classmethod
This reverts commit 7ee3d2f.
commented
Jul 21, 2025
|
|
commented
Jul 21, 2025
|
|
Closed
commented
Jul 22, 2025
|
|
commented
Jul 24, 2025
|
|
ghost
force-pushed
the
main
branch
3 times, most recently
from
July 24, 2025 16:55
5354959 to
2cf52b4
Compare
commented
Jul 24, 2025
|
|
ghost
deleted the
invalid-context-manager
branch
July 24, 2025 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Part of #5.
What changes are included in this PR?
Fixes the
invalid-context-manager. This fixes test cases where e.g. FlightClient was being overwritten withobjectwhich caused it to not have required methods to be used as context manager.Are these changes tested?
Yes, locally, type checking passes.
Are there any user-facing changes?
No.
invalid-context-manager#7