return UnknownValue if the usedbranch is unkown and the path is not e…

…mpty (#5846)
rollup · Feb 17, 2025 · ba692fe · ba692fe
1 parent f9c52f8
commit ba692fe
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 1 deletion.
diff --git a/src/ast/nodes/LogicalExpression.ts b/src/ast/nodes/LogicalExpression.ts
@@ -119,7 +119,7 @@ export default class LogicalExpression extends NodeBase implements Deoptimizable
 		if (usedBranch) {
 			this.expressionsToBeDeoptimized.push(origin);
 			return usedBranch.getLiteralValueAtPath(path, recursionTracker, origin);
-		} else if (!this.hasDeoptimizedCache) {
+		} else if (!this.hasDeoptimizedCache && !path.length) {
 			const rightValue = this.right.getLiteralValueAtPath(path, recursionTracker, origin);
 			const booleanOrUnknown = tryCastLiteralValueToBoolean(rightValue);
 			if (typeof booleanOrUnknown !== 'symbol') {

diff --git a/test/form/samples/logical-expression-with-property-access/_config.js b/test/form/samples/logical-expression-with-property-access/_config.js
@@ -0,0 +1,3 @@
+module.exports = defineTest({
+	description: 'keep logical expressions'
+});
diff --git a/test/form/samples/logical-expression-with-property-access/_expected.js b/test/form/samples/logical-expression-with-property-access/_expected.js
@@ -0,0 +1,8 @@
+const config = {
+	someComponent: { },
+	default: { config1: 'config1DefaultValue' }
+};
+
+var main = (config.someComponent || config.default).config1 || 'config1DefaultValue';
+
+export { main as default };
diff --git a/test/form/samples/logical-expression-with-property-access/main.js b/test/form/samples/logical-expression-with-property-access/main.js
@@ -0,0 +1,6 @@
+const config = {
+	someComponent: { someOtherConfig: false },
+	default: { config1: 'config1DefaultValue' }
+};
+
+export default (config.someComponent || config.default).config1 || 'config1DefaultValue';