Fix warning issued by AS log subscriber 7.1 and make bold again #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hampei
force-pushed
the
hh_log_subscriber71_warning
branch
from
86f0977 to
8337b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed for 7.2 in 6286722
But the warning is already present from rails 7.1.2 (7.2 is even an error, not a warning).
The previous fix turned the positional boolean into
{color: true}, but the only keys that do anything are bold/italic/underline, and the old true stood for bold, see: https://github.com/rails/rails/blob/v7.1.5.2/activesupport/lib/active_support/log_subscriber.rb#L190 and https://github.com/rails/rails/blob/v7.1.5.2/activesupport/lib/active_support/log_subscriber.rb#L70Arguments remain the same for for 7.2 https://github.com/rails/rails/blob/v7.2.2.2/activesupport/lib/active_support/log_subscriber.rb#L170 and 8.0 https://github.com/rails/rails/blob/v7.2.2.2/activesupport/lib/active_support/log_subscriber.rb#L170
No spec changes, since there is no appraisals, nor any existing specs around this.