Extend image handling, improve device checks, and fix signals#8
Open
ArthurLuciani2 wants to merge 3 commits intodevelopfrom
Open
Extend image handling, improve device checks, and fix signals#8ArthurLuciani2 wants to merge 3 commits intodevelopfrom
ArthurLuciani2 wants to merge 3 commits intodevelopfrom
Conversation
- Added `_type` attribute to track device type during registration and re-registration processes. - Implemented re-registration logic for devices if alive check fails with an `unregistered` response. - Updated `send_alive_check` function to return more detailed statuses: `ok`, `unreachable`, and `unknown`. - Adjusted logging to improve error and warning messages during device timeout and removal in `deviceregistry.py`. - Improved timeout handling in `send_alive_check` to differentiate between unreachable and unknown devices.
- Corrected the lambda function for `resolutionChanged` to unpack `res` properly using `*res`.
- Increased API token expiration in `scan.py` from `600` to `1800` seconds because 10 minutes is not enough when the format is png. - Added support for processing PNG images in `ImageProvider.py`, including handling rotations and transformations. - Removed image BGR to RGB conversion logic in `RPCCamera.py` for PNG encoding because it seems it already is in RGB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image Handling Enhancements:
ImageProvider.py, including transformations and rotations.scan.pyfrom 600 to 1800 seconds.RPCCamera.pyfor PNG encoding.Device Checks:
send_alive_checkinRPC.pyto return detailed statuses:ok,unreachable, andunknown.unregistered._typeattribute to track device types during registration and re-registration.Signal Fix:
resolutionChangedsignal connection by using*resin the lambda function.These changes improve image processing, device management, and fix a bug in signal handling.