Use Geist for UI text and Geist Mono for code text#4
Merged
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the app typography defaults so non-code UI text uses Geist and code/file-related text uses Geist Mono. It switches shared theme font tokens to Geist/Geist Mono, adds Geist Mono as a selectable font option, and makes it the default appearance font. It also updates i18n font option labels and the related e2e assertion so tests match the new default behavior.
How did you verify your code works?
I reviewed the full diff against
origin/devand confirmed all font wiring points (theme tokens, font-face loader, settings defaults/options, and e2e expectations) are internally consistent.