feat(Gateway): Expose bulkSetApprovalForAll NFT#112
Merged
Conversation
Contributor
Aderyn Analysis ReportThis report was generated by Aderyn, a static analysis tool built by Cyfrin, a blockchain security company. This report is not a substitute for manual audit or security review. It should not be relied upon for any purpose other than to assist in the identification of potential security vulnerabilities. Table of ContentsSummaryFiles Summary
Files Details
Issue Summary
High IssuesH-1: Unsafe Casting of integersDowncasting int/uints in Solidity can be unsafe due to the potential for data loss and unintended behavior.When downcasting a larger integer type to a smaller one (e.g., uint256 to uint128), the value may exceed the range of the target type,leading to truncation and loss of significant digits. Use OpenZeppelin's SafeCast library to safely downcast integers. 1 Found Instances
H-2: Yul block contains
|
TuDo1403
force-pushed
the
feature/set-nft-approval
branch
from
a2f08d6 to
8c09cf4
Compare
TuDo1403
commented
May 16, 2025
added 3 commits
May 16, 2025 13:44
Signed-off-by: tu-do.ron <tudo.dev@gmail.com>
TuDo1403
changed the title
TuDo1403
changed the title
setApprovalForAll NFT And burnAll
TuDo1403
commented
May 28, 2025
TuDo1403
changed the title
setApprovalForAll NFT And burnAllsetApprovalForAll NFT
TuDo1403
force-pushed
the
feature/set-nft-approval
branch
from
feceb57 to
af8e715
Compare
TuDo1403
changed the title
setApprovalForAll NFTbulkSetApprovalForAll NFT
huyhuynh3103
reviewed
Jun 3, 2025
Comment on lines
+96
to
+98
| if (msg.sender != _getProxyAdmin()) { | ||
| _checkRole(_MIGRATOR_ROLE); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why does this function allow calls from the proxy admin?
Author
There was a problem hiding this comment.
to support upgradeToAndCall in proposal
huyhuynh3103
reviewed
Jun 3, 2025
added 7 commits
June 4, 2025 16:41
…contract on ronin
TuDo1403
force-pushed
the
feature/set-nft-approval
branch
2 times, most recently
from
4037964 to
34a3c52
Compare
khang-sm
approved these changes
Jun 18, 2025
TuDo1403
force-pushed
the
feature/set-nft-approval
branch
from
2c545ca to
82c2515
Compare
TuDo1403
force-pushed
the
feature/set-nft-approval
branch
from
5f81a99 to
611ac45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
bulkSetApprovalForAllfunction in two gateway contracts to streamline NFT approval management and adjusts the optimizer runs in the configuration file. Below is a breakdown of the most important changes:New functionality for NFT approval management:
src/mainchain/MainchainGatewayV3.sol: Added thebulkSetApprovalForAllfunction, allowing admins or migrators to grant or revoke NFT transfer permissions for multiple operators in a single transaction. The function includes input validation to ensure the arrays have matching lengths.src/ronin/gateway/RoninGatewayV3.sol: Added the samebulkSetApprovalForAllfunction as inMainchainGatewayV3, with identical functionality and validation.Configuration adjustment:
foundry.toml: Reduced theoptimizer_runsparameter from 200 to 10, likely to optimize for faster compilation during development or testing.