eth/filters: enforce the limit of topics and sub-topics#8
Open
minh-bq wants to merge 2 commits intoronin-chain:masterfrom
Open
eth/filters: enforce the limit of topics and sub-topics#8minh-bq wants to merge 2 commits intoronin-chain:masterfrom
minh-bq wants to merge 2 commits intoronin-chain:masterfrom
Conversation
commit ethereum/go-ethereum@e38b9f1. Currently, geth's will return `[]` for any `len(topics) > 4` log filter. The EVM only supports up to four logs, via LOG4 opcode, so larger criterias fail. This change makes the filter query exit early in those cases.
commit ethereum/go-ethereum@ef5ac3f. This PR adds a limit of 1000 to the "inner" topics in a filter-criteria
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit ethereum/go-ethereum@e38b9f1.
Currently, geth's will return [] for any len(topics) > 4 log filter. The
EVM only supports up to four logs, via LOG4 opcode, so larger criterias fail.
This change makes the filter query exit early in those cases.
commit ethereum/go-ethereum@ef5ac3f.
This PR adds a limit of 1000 to the "inner" topics in a filter-criteria.