Correctly add fields to models (#32)

ronin-co · Jan 20, 2025 · 6dfc69a · 6dfc69a
1 parent a1ac9fe
commit 6dfc69a
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 19 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/src/utils/field.ts b/src/utils/field.ts
@@ -218,14 +218,7 @@ export const createFields = (
   const diff: Array<string> = [];
 
   for (const fieldToAdd of fields) {
-    const { ...field } = fieldToAdd;
-
-    const fieldValue = {
-      ...field,
-      model: { slug: modelSlug },
-    };
-
-    diff.push(createFieldQuery(modelSlug, fieldValue));
+    diff.push(createFieldQuery(modelSlug, fieldToAdd));
   }
 
   return diff;

diff --git a/src/utils/queries.ts b/src/utils/queries.ts
@@ -62,16 +62,6 @@ export const createModelQuery = (
  * ```
  */
 export const createFieldQuery = (modelSlug: string, field: ModelField): string => {
-  if (field.type === 'link') {
-    const fieldWithFlatTarget = field.target
-      ? {
-          ...field,
-          target: field.target,
-        }
-      : field;
-    return `alter.model('${modelSlug}').create.field(${JSON.stringify(fieldWithFlatTarget)})`;
-  }
-
   return `alter.model('${modelSlug}').create.field(${JSON.stringify(field)})`;
 };
 

diff --git a/tests/utils/field.test.ts b/tests/utils/field.test.ts
@@ -127,7 +127,7 @@ describe('fields', () => {
       const diff = await diffFields(localFields, remoteFields, 'account', [], []);
       expect(diff).toHaveLength(1);
       expect(diff).toStrictEqual([
-        'alter.model(\'account\').create.field({"type":"string","slug":"name","model":{"slug":"account"}})',
+        'alter.model(\'account\').create.field({"type":"string","slug":"name"})',
       ]);
     });