Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size by removing prettier in favor for dprint #51

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

colodenn
Copy link
Member

In this pull request, I introduced code formatting for generated migration files using Prettier. However, Prettier added an extra 7.5 MB to the bundle size, which significantly slowed down the CLI’s install process. As a result, I removed prettier and switched to dprint.

@colodenn colodenn requested a review from leo February 11, 2025 10:24
@colodenn colodenn self-assigned this Feb 11, 2025
Copy link

Released an experimental package:

bun add @ronin/cli@corny-ron-1098-experimental-123

This package will be removed after the pull request has been merged.

@colodenn colodenn marked this pull request as ready for review February 11, 2025 10:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/format.ts 100.00% <100.00%> (ø)
src/utils/protocol.ts 100.00% <100.00%> (ø)

@colodenn colodenn requested a review from NuroDev February 11, 2025 10:26
@colodenn colodenn merged commit eb0ccbe into main Feb 11, 2025
3 checks passed
@colodenn colodenn deleted the corny/ron-1098 branch February 11, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants