Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to process fields, indexes and triggers as objects #56

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

colodenn
Copy link
Member

@colodenn colodenn commented Feb 20, 2025

This PR updates ronin, which modified the representation of fields, indexes, and triggers in the syntax package. The behavior has been adjusted so that the CLI continues to work with the object representation. However, there are still some type errors and too many instances where arrays are used instead of objects and vice versa.

@colodenn colodenn requested a review from leo February 20, 2025 11:54
@colodenn colodenn self-assigned this Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

Released an experimental package:

bun add @ronin/cli@corny-latest-get-batch-proxy-experimental-134

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/field.ts 100.00% <100.00%> (ø)
src/utils/migration.ts 100.00% <100.00%> (ø)
src/utils/misc.ts 100.00% <100.00%> (ø)
src/utils/model.ts 100.00% <100.00%> (ø)
src/utils/protocol.ts 100.00% <100.00%> (ø)
src/utils/queries.ts 100.00% <100.00%> (ø)
tests/fixtures/index.ts 100.00% <100.00%> (ø)
tests/fixtures/utils.ts 100.00% <100.00%> (ø)

@colodenn colodenn changed the title Allow to process object fields, indexes and triggers Allow to process fields, indexes and triggers as objects Feb 20, 2025
@colodenn colodenn marked this pull request as ready for review February 20, 2025 13:01
@colodenn colodenn merged commit 8abd94f into main Feb 20, 2025
3 checks passed
@colodenn colodenn deleted the corny/latest-getBatchProxy branch February 20, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants