Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --choose flag to select specific migration file #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colodenn
Copy link
Member

@colodenn colodenn commented Feb 23, 2025

The ronin apply command has been updated to automatically apply the latest migration by default. Previously, the user was prompted to select which migration to apply each time. If you now wish to apply a specific migration, you can use the --choose flag, which will allow you to select a particular migration to apply.

@colodenn colodenn requested a review from leo February 23, 2025 10:05
@colodenn colodenn self-assigned this Feb 23, 2025
Copy link

Released an experimental package:

bun add @ronin/cli@corny-ron-1099-3-experimental-136

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/migration.ts 100.00% <100.00%> (ø)

@colodenn colodenn marked this pull request as ready for review February 23, 2025 10:06
Copy link
Member

@leo leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I fully understand the logic behind this flag.

If I know that I want to choose, doesn't that mean I also already know the migration that I want to choose? So why make me waste time by doing that, instead of letting me just pass the migration as an argument to the command?

Perhaps I'm misunderstanding.

@colodenn
Copy link
Member Author

I'm not sure I fully understand the logic behind this flag.

If I know that I want to choose, doesn't that mean I also already know the migration that I want to choose? So why make me waste time by doing that, instead of letting me just pass the migration as an argument to the command?

Perhaps I'm misunderstanding.

Nikita was longing for the ability to execute ronin apply to apply the latest migration. Additionally, he wants the option to specify a particular migration file to run, a feature we already support. Lastly, he suggested having an interactive prompt (--choose) to select a migration from a list of available migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants