Ensure correct pagination while counting #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released an experimental package: bun add ronin@leo-ron-1099-experimental-70This package will be removed after the pull request has been merged. |
colodenn
approved these changes
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the following query works without problems:
In other words: The compiler normally requires a
limitedToinstruction to be present when paginating. When counting, however, people often want to determine the total amount of available records before or after a given counter, so we should not require thelimitedToinstruction in that case.This change was originally landed in ronin-co/compiler#136.