Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure syntax proxy removes undefined instructions #73

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

NuroDev
Copy link
Member

@NuroDev NuroDev commented Feb 21, 2025

This change ensures that the getSyntaxProxy removes any instruction properties that are undefined.

Additionally this fixes a broken test that was reporting a false positive & adds another test to ensure issues like this do not happen again.

Before

get.accounts({ after: undefined });
// { __RONIN_QUERY: { get: { accounts: { after: undefined } } } }

After

get.accounts({ after: undefined });
// { __RONIN_QUERY: { get: { accounts: {} } } }

Originally, the change was landed in ronin-co/syntax#59.

@NuroDev NuroDev requested review from leo and colodenn February 21, 2025 13:08
@NuroDev NuroDev self-assigned this Feb 21, 2025
@NuroDev NuroDev enabled auto-merge (squash) February 21, 2025 13:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link

Released an experimental package:

bun add ronin@ben-ron-1099-experimental-102

This package will be removed after the pull request has been merged.

@NuroDev NuroDev merged commit b01a47d into main Feb 21, 2025
5 checks passed
@NuroDev NuroDev deleted the ben/ron-1099 branch February 21, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants