Correctly update fields when changing their slug (#147)

ronin-co · Feb 19, 2025 · 9468895 · 9468895
1 parent ab31f1d
commit 9468895
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/model/index.ts b/src/model/index.ts
@@ -1107,9 +1107,14 @@ export const transformMetaQuery = (
           newSlug,
           Object.getOwnPropertyDescriptor(targetEntities, slug)!,
         );
+
+        // Assign the newly generated attributes to the new entity.
+        Object.assign(targetEntities[newSlug], entityValue);
+
+        // Remove the old entity.
         delete targetEntities[slug];
 
-        const value = prepareStatementValue(statementParams, entityValue);
+        const value = prepareStatementValue(statementParams, targetEntities[newSlug]);
         json = `json_insert(json_remove(${field}, '$.${slug}'), '$.${newSlug}', ${value})`;
       }
       // Otherwise, just update the existing property.

diff --git a/tests/meta.test.ts b/tests/meta.test.ts
@@ -771,7 +771,7 @@ test('alter existing field (slug)', () => {
     },
     {
       statement: `UPDATE "ronin_schema" SET "fields" = json_insert(json_remove("fields", '$.email'), '$.emailAddress', ?1), "ronin.updatedAt" = strftime('%Y-%m-%dT%H:%M:%f', 'now') || 'Z' WHERE "slug" = ?2 RETURNING "id", "ronin.createdAt", "ronin.createdBy", "ronin.updatedAt", "ronin.updatedBy", "name", "pluralName", "slug", "pluralSlug", "idPrefix", "table", "identifiers.name", "identifiers.slug", "fields", "indexes", "triggers", "presets"`,
-      params: [JSON.stringify({ name: 'Email Address' }), 'account'],
+      params: [JSON.stringify({ type: 'string', name: 'Email Address' }), 'account'],
       returning: true,
     },
   ]);
@@ -819,7 +819,15 @@ test('alter existing field (slug) with many-cardinality relationship', () => {
     },
     {
       statement: `UPDATE "ronin_schema" SET "fields" = json_insert(json_remove("fields", '$.followers'), '$.subscribers', ?1), "ronin.updatedAt" = strftime('%Y-%m-%dT%H:%M:%f', 'now') || 'Z' WHERE "slug" = ?2 RETURNING "id", "ronin.createdAt", "ronin.createdBy", "ronin.updatedAt", "ronin.updatedBy", "name", "pluralName", "slug", "pluralSlug", "idPrefix", "table", "identifiers.name", "identifiers.slug", "fields", "indexes", "triggers", "presets"`,
-      params: [JSON.stringify({ name: 'Subscribers' }), 'account'],
+      params: [
+        JSON.stringify({
+          type: 'link',
+          target: 'account',
+          kind: 'many',
+          name: 'Subscribers',
+        }),
+        'account',
+      ],
       returning: true,
     },
   ]);