Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent actions for many-cardinality link fields #132

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

leo
Copy link
Member

@leo leo commented Feb 3, 2025

On RONIN, link field constraints are designed to prevent the existence of children that don't have parents, and link field actions exist to automatically handle the children if something happens to the parents.

It therefore doesn't make sense to offer link field actions for many-cardinality relationships, since, in those cases, parents are referencing children, and parents should never be affected if something happens to the children, since there can be many children and only one parent.

Lastly, if the parents disappear, their references to the children should also disappear.

@leo leo added the enhancement New feature or request label Feb 3, 2025
@leo leo requested review from NuroDev, juriadams and colodenn February 3, 2025 20:07
Copy link

github-actions bot commented Feb 3, 2025

Released an experimental package:

bun add @ronin/compiler@leo-ron-1099-1-experimental-361

This package will be removed after the pull request has been merged.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/model/index.ts 100.00% <100.00%> (ø)

@leo leo marked this pull request as ready for review February 3, 2025 20:08
@leo leo enabled auto-merge (squash) February 3, 2025 20:08
@leo leo merged commit 7fff56c into main Feb 3, 2025
4 checks passed
@leo leo deleted the leo/ron-1099-1 branch February 3, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants