-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for inlining statement values #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RON-1083 Improve query compiler further before release
Now that RON-1049 has landed, I am placing my personal list of future improvements for the query transformer on Linear, to prevent it from getting lost as I will begin working on the output transformer. We have to tackle those improvements before launching the transformer publicly.
Open Questions
|
Released an experimental package: bun add @ronin/compiler@leo-ron-1083-experimental This package will be removed after the pull request has been merged. |
leo
commented
Nov 8, 2024
colodenn
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an option to the compiler that makes it possible to inline all SQL statement values:
This option is useful for cases where the SQL output will be manually verified by a developer, such as when prompting RONIN to generate the migration protocol as SQL. In that case, a human will review the SQL before it is run, so it must be as clean as possible, and include all values right there, in place.
Furthermore, as you can see above, the exported method was renamed from
compileQueryInput
tocompileQuery
and no longer supports any internal options — only publicly available options.