Allow for passing trigger effects as query symbols #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released an experimental package: bun add @ronin/compiler@corny-ron-1099-experimental-384This package will be removed after the pull request has been merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
leo
changed the title
leo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the syntax package wraps queries within
trigger.effectsusing a query symbol. This causes issues with the compiler, as it incorrectly interprets the query symbol as a query type, such as add or create, due to object destructuring. This PR addresses this issue to ensure proper handling of queries by the compiler.