Avoid using params for schema statements #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released an experimental package: bun add @ronin/compiler@leo-ron-1071-experimental-292This package will be removed after the pull request has been merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
leo
changed the title
leo
changed the title
leo
changed the title
leo
changed the title
colodenn
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite does not support statement parameters in schema statements, which is currently blocking a different PR, so we have to stop using them for indexes and triggers.
Since schema-altering statements like trigger creation, index creation and so on are anyways not run by end-users, the SQLite team likely intentionally didn't want to prevent SQL injections here. Those kinds of queries are also not run repeatedly, so the performance optimization of needing to prepare statements with different values is also not helpful in those cases.