-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for advanced expressions #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Released an experimental package: bun add @ronin/syntax@corny-ron-1099-1-experimental-102 This package will be removed after the pull request has been merged. |
colodenn
commented
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
…into corny/ron-1099-1
leo
previously requested changes
Feb 4, 2025
Co-authored-by: Leo Lamprecht <[email protected]>
NuroDev
reviewed
Feb 4, 2025
NuroDev
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for advanced expressions such as:
However, there are still some missing type hints. We want to discourage expressions like:
where database-level expressions are used inside default values. Instead, users should use:
so that the value is evaluated at runtime rather than by the database. This change ensures clearer separation between client-side evaluation and database-generated expressions, improving both type safety and overall code maintainability.