Type model fields as non-nullable #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released an experimental package: bun add @ronin/syntax@ben-ron-1099-experimental-142This package will be removed after the pull request has been merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
colodenn
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally as part of #38 the types inferred from models were set up to make fields nullable if they are marked as required. However, since then this functionality seems to have regressed.
After some investigating the solution seems a little more complex since the boolean value from the field is not explicit. As such for the time being I have reverted that change & so now fields are no longer always
null.