Enforce stricter types & type tests #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released an experimental package: bun add @ronin/syntax@ben-ron-1099-experimental-145This package will be removed after the pull request has been merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
NuroDev
commented
Feb 18, 2025
leo
requested changes
Feb 19, 2025
leo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of many for this package to improve the TypeScript types to make them stricter, more robust & simpler for the end user to interact with.
As part of this first wave I have introduced
expect-typeto allow for type checking in tests, along with some other minor refactoring & adding of comments.