[Jules] Migrate jQuery snackbars to React components #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ronshapiro
commented
Jul 6, 2025
ronshapiro
commented
- Introduced a new React-based snackbar system with a GenericSnackbar component and a SnackbarProvider for managing snackbar state.
- Migrated existing snackbar kinds (PreferencesNudge, GoogleSignIn, Share, Errors, TextSelection, ReportedIssueSent) from the old jQuery-based snackbar.ts to new React trigger components or callable functions.
- Integrated the new system into Root.tsx, allowing snackbars to be stacked and managed globally.
- Refactored SnackbarReact.tsx (for search) to use the new GenericSnackbar component internally.
- Added CSS for the new generic snackbar system.
- Improved robustness of snackbar dismissal with an onAnimatedOut callback.
- Added support for disabled buttons in snackbars.
- Cleaned up by removing the old js/snackbar.ts file.
- Introduced a new React-based snackbar system with a GenericSnackbar component and a SnackbarProvider for managing snackbar state. - Migrated existing snackbar kinds (PreferencesNudge, GoogleSignIn, Share, Errors, TextSelection, ReportedIssueSent) from the old jQuery-based snackbar.ts to new React trigger components or callable functions. - Integrated the new system into Root.tsx, allowing snackbars to be stacked and managed globally. - Refactored SnackbarReact.tsx (for search) to use the new GenericSnackbar component internally. - Added CSS for the new generic snackbar system. - Improved robustness of snackbar dismissal with an onAnimatedOut callback. - Added support for disabled buttons in snackbars. - Cleaned up by removing the old js/snackbar.ts file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.