[v636][ntuple] Fix type names with [U]Long64_t template args #20600
+227
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport a minimal subset of the improvements of commit 705376f We don't backport part of the changes that implement RNTuple normalization of demangled paths. But we do apply some improvements to the renormalization of meta-normalized paths. This is a precondition to cleanly apply the series of patches fixing [U]Long64_t in template parameters.
This restriction is actually not required. (cherry picked from commit 0ce3049)
(cherry picked from commit 1648058)
Custom classes with [U]Long64_t template arguments need to use their meta-normalized name as type alias. Otherwise, during reconstruction with the RNTuple normalized name, the streamer info for the `std::[u]int64_t` argument will be requested (typically `long` instead of `long long`). (cherry picked from commit 6124192)
(cherry picked from commit 571411b)
(cherry picked from commit 9a821aa)
(cherry picked from commit cc32bb6)
Clarify treatment of ROOT fundamental typedefs, including special treatment of `[U]Long64_t`. (cherry picked from commit b140667)
Test Results 16 files 16 suites 2d 12h 4m 0s ⏱️ For more details on these failures, see this check. Results for commit 285eaed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20478
Non-trivial backport.