Skip to content

Updated on_call_role to be custom and added support for non-editable form field placements #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Updated on_call_role to be custom and added support for non-editable form field placements #122

wants to merge 9 commits into from
+6 −7

Conversation

udai1931
Copy link
Contributor

kwent
kwent previously approved these changes Sep 12, 2025
View reviewed changes
@udai1931
Copy link
Contributor Author

@alexmingoia Can you please check the failing test? It's not related to my changes.
In which team we need to add a alert source so that this will pass?

image

alexmingoia
alexmingoia previously approved these changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@alexmingoia alexmingoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to exclude this resource from code generation (in tools/generate.js), otherwise these changes will get overwritten the next time someone runs code generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwent kwent kwent left review comments

@alexmingoia alexmingoia alexmingoia left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udai1931 @kwent @alexmingoia