Add spec files for mars components #10

santiagodiaz · 2025-10-23T20:16:26Z

Add new spec files for Mars::Agent, Mars::Aggregator and Mars::Gate to improve test coverage.

cursor · 2025-10-23T20:16:27Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

.cursor/environment.json

.gitignore

santib · 2025-10-23T21:06:47Z

.rubocop.yml

+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/VerifiedDoubleReference:
+  Enabled: false


RSpec/VerifiedDoubleReference: Enabled: false
was added because of the instance_double line for skipping this rubocop offense:

spec/mars/agent_spec.rb:7:23: C: [Correctable] RSpec/VerifiedDoubleReference: Use a constant class reference for verified doubles. String references are not verifying unless the class is loaded. instance_double("RubyLLM::Chat").tap do |mock|

I think it depends if we want to keep that test that is mocking the rubyllm chat in agent_spec.rb

spec/mars/agent_spec.rb

santib · 2025-10-23T21:08:18Z

spec/mars/agent_spec.rb

+      allow(agent).to receive(:chat).and_return(mock_chat)
+      allow(mock_chat).to receive(:ask).with("test input").and_return("response")
+
+      result = agent.run("test input")
+
+      expect(result).to eq("response")
+      expect(mock_chat).to have_received(:ask).with("test input")
+    end


everything is so mocked that I'm not sure these tests add value at all

santib

When using AI for tests it usually generates all this. It happened to me but I trimmed it to just the tests that add value, check https://github.com/rootstrap/mars/blob/main/spec/mars/workflows/sequential_spec.rb and https://github.com/rootstrap/mars/blob/main/spec/mars/runnable_spec.rb as examples

Co-authored-by: santiago.d.diaz <[email protected]>

santiagodiaz marked this pull request as ready for review October 23, 2025 20:59