Update parallel workflow using async gem #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagodiaz
changed the title
santib
reviewed
Oct 30, 2025
| return yield if block_given? | ||
|
|
||
| inputs.join("\n") | ||
| operation.call(inputs) |
There was a problem hiding this comment.
why do we need this operation? I'm a bit worried about allowing random Ruby code because it may affect out ability to accurately describe workflows as diagrams right?
what I mean is that I could have an operation be ->(inputs) { raise 'error' } and then we don't have any way to detect that during the diagram rendering
santib
reviewed
Oct 30, 2025
lib/mars/workflows/parallel.rb
Outdated
| @@ -1,5 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "async" | |||
There was a problem hiding this comment.
I think it's better to keep requires in the lib/mars.rb gem's root file
santib
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
asyngemAggregateErrorclass