Use release script when deploying with containers #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santib
approved these changes
Mar 11, 2025
santib
reviewed
Mar 11, 2025
| bundle exec rails db:migrate | ||
| bundle exec rails feature_flags:initialize | ||
| echo "Running release script" && | ||
| bundle exec rails feature_flags:initialize |
There was a problem hiding this comment.
should the db:migrate command be here as well?
There was a problem hiding this comment.
We are running the migrations in the entrypoint script. Rails does the same here.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the release script was not executed during container-based deployments on Heroku. It adds a "release" section in the heroku.yml file to ensure that the custom release script is run during deployment.
- Adds a new release section with the appropriate script call.
- Ensures that the web image is used for the release phase.
Comments suppressed due to low confidence (1)
heroku.yml:17
- Ensure that './bin/release.sh' exists and is executable in the repository to prevent deployment failures.
- ./bin/release.sh
PerezIgnacio
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When using the
heroku.ymlto deploy apps with the container stack on Heroku, the release script is not being executed. This PR fixes the issue by adding the script into theheroku.ymlfile.Note: Migrations are executed as part of the
docker-entrypointscript, so we don't need to run them during the release phase (just like Rails does in this template)