Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint configuration, apply prettier rules #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fernandatoledo
Copy link
Collaborator

What does this do?

This PR updates the .eslintrc.js file to apply Prettier rules as part of the linting process. Additionally, the rule @typescript-eslint/ban-types was disabled because it was throwing a "rule not found" error.

Why did you do this?

Prettier was not being enforced correctly through pnpm lint, leading to inconsistencies in code formatting. Disabling @typescript-eslint/ban-types was necessary because it no longer exists in the latest versions of @typescript-eslint/eslint-plugin, causing linting to fail.

Who/what does this impact?

  • Since this change impacts formatting rules, it modified multiple files.

How did you test this?

  • Ran pnpm lint to confirm that Prettier is now applied correctly.
  • Verified that disabling @typescript-eslint/ban-types resolved the "rule not found" error.
  • Reviewed the affected files to ensure proper formatting.

@fernandatoledo fernandatoledo requested a review from a team as a code owner February 28, 2025 12:57
@fernandatoledo fernandatoledo changed the title Fix linter ESLint configuration, apply prettier rules Feb 28, 2025
Copy link

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 50%
50% (341/682) 44.52% (122/274) 36.32% (85/234)

😎 Tests Results

Tests Skipped Failures Errors Time
77 0 💤 0 ❌ 0 🔥 30.126s ⏱️
👀 Tests Details • (50%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files5044.5236.3250.38 
api/common79.1663.3364.781.15 
   utils.tsx85.7157.1458.3390.6214–20
components47.0566.6642.8547.05 
   buttons.tsx0100005–6
   colors.tsx100100100100 
   title.tsx100100100100 
   typography.tsx0100005–6
components/settings0000 
   theme-item.tsx01000010–36
core53.12035.7160.71 
   utils.ts6002085.715
core/hooks26.310026.31 
   use-selected-theme.tsx23.070023.0717–29, 33–35
core/i18n5023.075048.14 
   index.tsx100100100100 
   types.ts0000 
ui77.7263.0769.2377.41 
   checkbox.tsx10081.08100100126–160, 182, 221, 243
   image.tsx60006016, 25
   input.tsx10085.7110010098, 120
   list.tsx60006014, 27
   modal-keyboard-aware-scroll-view.tsx100100100100 
   progress-bar.tsx1007510010022
   text.tsx1006010010034–42
ui/icons52.1708.3352.17 
   settings.tsx5000505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants