Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For comparison #2

Closed
wants to merge 1 commit into from
Closed

For comparison #2

wants to merge 1 commit into from

Conversation

maelle
Copy link
Member

@maelle maelle commented Sep 21, 2018

And here's what R told me

> testApp("inst/colocr_app")
Running one_image.R setInputs(app$setInputs(threshold = 90)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(clean = 8)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(fill = 8)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(shrink = 6)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(roi_num = 2)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(roi_num = 3)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(fill = 5)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(clean = 10)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(shrink = 8)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(fill = 10)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
two_images.R setInputs(app$setInputs(threshold = 90)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.
setInputs(app$setInputs(roi_num = 3)): Server did not update any output values within 3 seconds. If this is expected, use `wait_=FALSE, values_=FALSE`, or increase the value of timeout_.

==== Comparing one_image... 
  No existing snapshots at one_image-expected/. This is a first run of tests.

Updating baseline results at inst/colocr_app/tests/one_image-expected...
Renaming inst/colocr_app/tests/one_image-current
      => inst/colocr_app/tests/one_image-expected.
==== Comparing two_images... 
  No existing snapshots at two_images-expected/. This is a first run of tests.

Updating baseline results at inst/colocr_app/tests/two_images-expected...
Renaming inst/colocr_app/tests/two_images-current
      => inst/colocr_app/tests/two_images-expected.

cf ropensci/software-review#243 (comment)

@maelle
Copy link
Member Author

maelle commented Sep 21, 2018

Am going to run the app manually now

@maelle
Copy link
Member Author

maelle commented Sep 21, 2018

image

All I can do for now, good luck!

@maelle
Copy link
Member Author

maelle commented Sep 21, 2018

Can you give me minimal code using imager? Then we could open an issue in their repo if that's the problem

@maelle
Copy link
Member Author

maelle commented Sep 21, 2018

Or you can switch to magick by @jeroen if it appears that imager is the problem. 😉

@MahShaaban
Copy link
Collaborator

Thanks @maelle. I wonder what happen when you run the tests again after the expected images are created. This is what I meant by running shinytest::testApp() again. Sorry for not being clear in my suggestion.

@maelle
Copy link
Member Author

maelle commented Sep 21, 2018

I cant try now but I'd get the same results again I think, since I alsp got them when running the app manually.

@maelle maelle closed this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants