docs: add agent iOS release skill#39
Conversation
📝 WalkthroughWalkthroughThis PR adds documentation for a new Changesasc-agent-ios-release Skill Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/asc-agent-ios-release/SKILL.md`:
- Around line 34-39: Update Step 2 to explicitly show how to resolve both
VERSION/BUILD_ID and PREVIOUS_VERSION: run the existing commands to get VERSION
and BUILD_ID (asc versions list and asc builds info), then add a command using
asc versions list --app "$APP_ID" --platform IOS --state READY_FOR_SALE --output
json (or similar) to locate the latest published version and set
PREVIOUS_VERSION accordingly before Step 4 so that the --copy-metadata-from flag
has a defined value; reference the variables VERSION, BUILD_ID, and
PREVIOUS_VERSION and the asc versions list / asc builds info commands in the doc
update.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9bf11365-3334-4457-9ead-b85513047984
📒 Files selected for processing (2)
README.mdskills/asc-agent-ios-release/SKILL.md
| 2. Resolve the target version and build: | ||
|
|
||
| ```bash | ||
| asc versions list --app "$APP_ID" --platform IOS --output json | ||
| asc builds info --app "$APP_ID" --latest --version "$VERSION" --platform IOS --output json | ||
| ``` |
There was a problem hiding this comment.
Clarify the version resolution step.
Step 2 resolves VERSION and BUILD_ID, but later in step 4 (lines 61, 73), the workflow uses $PREVIOUS_VERSION for the --copy-metadata-from flag. The documentation should show how to resolve or identify PREVIOUS_VERSION in this step.
📝 Suggested addition
Consider adding a command to help identify the previous version:
2. Resolve the target version and build:
```bash
asc versions list --app "$APP_ID" --platform IOS --output json
asc builds info --app "$APP_ID" --latest --version "$VERSION" --platform IOS --output json
+# Identify the previous version if you plan to copy metadata:
+asc versions list --app "$APP_ID" --platform IOS --state READY_FOR_SALE --output json
</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
2. Resolve the target version and build:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/asc-agent-ios-release/SKILL.md` around lines 34 - 39, Update Step 2 to
explicitly show how to resolve both VERSION/BUILD_ID and PREVIOUS_VERSION: run
the existing commands to get VERSION and BUILD_ID (asc versions list and asc
builds info), then add a command using asc versions list --app "$APP_ID"
--platform IOS --state READY_FOR_SALE --output json (or similar) to locate the
latest published version and set PREVIOUS_VERSION accordingly before Step 4 so
that the --copy-metadata-from flag has a defined value; reference the variables
VERSION, BUILD_ID, and PREVIOUS_VERSION and the asc versions list / asc builds
info commands in the doc update.
1 participant
Summary
Verification
Summary by CodeRabbit
ascCLI tool for staging and submitting iOS releases.