Skip to content

feat: wireless monitor #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

reinzor
Copy link
Member

@reinzor reinzor commented Nov 18, 2019

Monitors a given wireless interface using psutil and iwconfig. Follow up of #8 (comment)

@k-okada
Copy link
Contributor

k-okada commented Nov 18, 2019

Thanks, so should we Close #8 and use this one? Please set version 0.2.1 for your package.xml

@reinzor
Copy link
Member Author

reinzor commented Nov 18, 2019

I guess so. Regarding the version bump, I think this should always be up to the maintainer who makes the release with the required catkin release tools: catkin_generate_changelog, catkin_prepare_release and bloom-release.

@k-okada
Copy link
Contributor

k-okada commented Nov 18, 2019

Ok, before that , please add ‘wireless-tools` rosdep keys, os use available key. https://travis-ci.com/ros-drivers/linux_peripheral_interfaces/builds/136987617

  - wireless-tools
1724Traceback (most recent call last):
1725  File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 271, in resolve_names
1726    rosdep_key, view, installer, os_name, os_code_name)
1727  File "/usr/lib/python3/dist-packages/rosdep2/catkin_support.py", line 87, in resolve_for_os
1728    d = view.lookup(rosdep_key)
1729  File "/usr/lib/python3/dist-packages/rosdep2/lookup.py", line 197, in lookup
1730    return self.rosdep_defs[rosdep_name]
1731KeyError: 'wireless-tools'
1732
1733During handling of the above exception, another exception occurred:
1734
1735Traceback (most recent call last):
1736  File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 287, in <module>
1737    main()
1738  File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 144, in main
1739    run_and_test_depends, **context)
1740  File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 274, in resolve_names
1741    "Could not resolve the rosdep key '%s'" % rosdep_key)
1742RuntimeError: Could not resolve the rosdep key 'wireless-tools'
1743The command "cd $JOB_PATH; sh ./prerelease.sh -y" failed and exited with 1 during .
1744
1745Your build has been stopped.

nuclearsandwich pushed a commit to ros/rosdistro that referenced this pull request Nov 27, 2019
@reinzor
Copy link
Member Author

reinzor commented Dec 12, 2019

ping! ros/rosdistro#23060 is merged

@reinzor
Copy link
Member Author

reinzor commented Apr 29, 2020

There seems to be interest in this. Any time to look at this PR? Otherwise I will close it due to inactivity.

@reinzor
Copy link
Member Author

reinzor commented Sep 18, 2020

Nobody seems to care, closing PR

@reinzor reinzor closed this Sep 18, 2020
@130s
Copy link
Member

130s commented Sep 20, 2021

@reinzor @furushchev nice work!
I'm just not sure if wifi capability is worth a new package (I'm afraid doing so would raise the level of maintenance burden).

Without knowing this PR, I opened #20 to add a pkg to cover functionalities for non-sensor, computer hardware (as there's already a pkg for sensors on this repo). If it makes sense, I'm interested in adding your work into the new package I'm suggesting to add.

(Since #20 is supposed to be a generalized copy of the package that has existed somewhere else, I want to keep #20 as is. I can add the wifi stuff in another PR).

@reinzor
Copy link
Member Author

reinzor commented Sep 20, 2021

Thanks @130s , I don't think this package is actively maintained anymore but you can try to ping the maintainers. Would be nice to see this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants