Fix for issue #82: incorrect base_link->link_1 transform (IRB 1200-5/0.9) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Levi-Armstrong: if you could take a look? I'll merge once this is accepted. |
Levi-Armstrong
approved these changes
Jan 3, 2018
gavanderhoorn
changed the title
Docs (3HAC046982-001, rev. G) spec a 0.3991m translation in Z direction, while xacro had it at 0.399m.
gavanderhoorn
force-pushed
the
irb1200_5_90_wrong_transform
branch
from
cde9add to
9cbaf8c
Compare
|
Thanks @Levi-Armstrong for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per subject.
This adds
0.0001mto the Z translation, as per specs document.