Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fasten rosversion --all #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/rospkg/rospack.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
from .stack import InvalidStack, parse_stack_file

_cache_lock = Lock()
path_cache = {}


def list_by_path(manifest_name, path, cache):
Expand All @@ -68,7 +69,12 @@ def list_by_path(manifest_name, path, cache):
continue # leaf
if PACKAGE_FILE in files:
# parse package.xml and decide if it matches the search criteria
root = ElementTree(None, os.path.join(d, PACKAGE_FILE))
tmp_path = os.path.join(d, PACKAGE_FILE)
if tmp_path in path_cache:
root = path_cache[tmp_path]
else:
root = ElementTree(None, os.path.join(d, PACKAGE_FILE))
path_cache[tmp_path] = root
is_metapackage = root.find('./export/metapackage') is not None
if (
(manifest_name == STACK_FILE and is_metapackage) or
Expand Down