Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export CMAKE_CXX_STANDARD if log4cxx requires C++17 #1

Open
cosama opened this issue Feb 21, 2025 · 1 comment · May be fixed by #2
Open

export CMAKE_CXX_STANDARD if log4cxx requires C++17 #1

cosama opened this issue Feb 21, 2025 · 1 comment · May be fixed by #2

Comments

@cosama
Copy link

cosama commented Feb 21, 2025

I ran into ros#56 while building geometry2 on ubuntu22.04. Not sure why it has been seen before, but after applying that patch to the code here it build just fine. According to the discussion in the pull request the patch is compatible with ubuntu20.04 so shouldn't have any adversarial effect.

It is a bit cumbersome to apply the patch manually so if we could do it here that would be pretty awesome.
@cosama
Copy link
Author

cosama commented Mar 4, 2025

I just tested this also on ubuntu 24.04 and it worked as well.

@cosama cosama linked a pull request Mar 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

export CMAKE_CXX_STANDARD if log4cxx requires C++17 cosama/rosconsole
1 participant
@cosama