Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2::doTransform<sensor_msgs::PointCloud2> doesn't transform normals and viewpoints #387

Open
peci1 opened this issue Jul 1, 2019 · 2 comments

Comments

@peci1
Copy link
Contributor

peci1 commented Jul 1, 2019

I've noticed that tf2::doTransform<sensor_msgs::PointCloud2> from tf2_sensor_msgs only transforms the XYZ fields, and leaves normals and viewpoints untransformed. I can either send a PR adding support for this (if the channels are present), or there should be a warning that the pointcloud was transformed but not its normals and viewpoints. What solution does sound better?

There could also be a new helper function called transformChannel or similar, that would take a pointcloud, channel prefix and transform, and apply the transform to all points in the given channel (appending x, y and z to the channel prefix).

@tfoote
Copy link
Member

tfoote commented Jul 10, 2019

A PR to extend support for the other channels would be great.

@peci1
Copy link
Contributor Author

peci1 commented Jul 10, 2019

See #396.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants