Skip to content

Added README.md for dummy_robot_bringup. #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 6, 2025
Merged

Added README.md for dummy_robot_bringup. #574

merged 11 commits into from
Oct 6, 2025

Conversation

cardboardcode
Copy link
Contributor

Purpose of Pull Request

This pull request adds a README.md to dummy_robot_bringup as part of efforts to address the issue highlighted in #531.

@cardboardcode
➕ 📖 Added dummy_robot_bringup README.md. Modified package toproduce d…
699b0dc 
…ocumented expected behaviour. Verified instructions.

Signed-off-by: Bey Hao Yun <[email protected]>
@cardboardcode cardboardcode changed the title Added dummy_robot_bringup README.md. Added README.md for dummy_robot_bringup . Jul 26, 2022
@cardboardcode cardboardcode changed the title Added README.md for dummy_robot_bringup . Added README.md for dummy_robot_bringup. Jul 26, 2022
@audrow audrow self-assigned this Jul 26, 2022
@audrow audrow self-requested a review July 26, 2022 17:01
@cardboardcode cardboardcode marked this pull request as draft August 13, 2022 16:19
@cardboardcode
🔨 Adhered dummy_robot_bringup README.md to approved style of instruct…
20bb225 
…ions for better cross-platform-compatibility.

Signed-off-by: Bey Hao Yun <[email protected]>
@cardboardcode cardboardcode marked this pull request as ready for review January 23, 2023 15:53
clalancette
clalancette requested changes Jan 23, 2023
View reviewed changes
@adityapande-1995
Copy link
Contributor

Testing for dependency cycles :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

adityapande-1995
adityapande-1995 requested changes Mar 9, 2023
View reviewed changes
@cardboardcode
Resolved flake error.
8b5abbb 
Signed-off-by: Bey Hao Yun <[email protected]>
adityapande-1995
adityapande-1995 reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please resolve the conflicts here @cardboardcode ? Looks good to me otherwise.

@cardboardcode
Copy link
Contributor Author

Rebased pull request branch to newly updated main rolling branch. Conflicts should now be resolved.

ahcorde added 3 commits October 2, 2025 16:37
@ahcorde
Merge branch 'rolling' into add_dummy_robot_bringup_readme
8c3137e 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Added some fixes
6fb20d5 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Fixes
a3f56b3 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Oct 2, 2025

Pulls: #574
Gist: https://gist.githubusercontent.com/ahcorde/9f787518ebfbaa2f54982a80b47ae0b5/raw/003efa698ddb44d9283107681f75423d4f19d81f/ros2.repos
BUILD args: --packages-above-and-dependencies dummy_robot_bringup
TEST args: --packages-above dummy_robot_bringup
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17154

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Added exec dependency
166dcbf 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
fujitatomoya
fujitatomoya reviewed Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde thanks for taking the effort on this.

there are a few flake8 warnings to address.

https://ci.ros2.org/job/ci_linux-aarch64/19341/testReport/junit/(root)/projectroot/flake8/

@ahcorde
make linters happy
4af681e 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Oct 3, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 35a91bd into ros2:rolling Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 requested changes

@ahcorde ahcorde ahcorde approved these changes

@audrow audrow Awaiting requested review from audrow

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

@clalancette clalancette Awaiting requested review from clalancette

@fujitatomoya fujitatomoya Awaiting requested review from fujitatomoya

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cardboardcode @adityapande-1995 @ahcorde @clalancette @audrow @fujitatomoya