update get_log_file_path for backward compatibility

Signed-off-by: Tanishq Chaudhary <[email protected]>

Author: Tanishq30052002

launch/launch/logging/__init__.py

@@ -315,13 +315,14 @@ def set_log_format(self, log_format, *, log_style=None):
         else:
             self.file_formatter = None
 
-    def get_log_file_path(self):
+    def get_log_file_path(self, log_file_name='launch.log'):
         """
         Get the absolute path to the given log file.
 
+        :param log_file_name: name of the file for which we want full path
         :return: the absolute path to the log file.
         """
-        return os.path.join(self.log_dir, self.log_file_name)
+        return os.path.join(self.log_dir, log_file_name)
 
     def get_log_file_handler(self):
         """
@@ -335,7 +336,8 @@ def get_log_file_handler(self):
         """
         if self.log_file_name not in self.file_handlers:
             factory = self.log_handler_factory
-            file_handler = factory(self.get_log_file_path(), encoding='utf-8')
+            file_handler = factory(
+                self.get_log_file_path(self.log_file_name), encoding='utf-8')
             file_handler.setFormatter(self.file_formatter)
             self.file_handlers[self.log_file_name] = file_handler
         return self.file_handlers[self.log_file_name]

launch/test/launch/test_logging.py

@@ -131,7 +131,8 @@ def test_output_loggers_configuration(
     assert 0 == len(capture.err)
 
     launch.logging.launch_config.log_file_name = main_log_file_name
-    main_log_path = launch.logging.launch_config.get_log_file_path()
+    main_log_path = launch.logging.launch_config.get_log_file_path(
+        launch.logging.launch_config.log_file_name)
     assert os.path.exists(main_log_path)
     assert 0 != os.stat(main_log_path).st_size
     with open(main_log_path, 'r') as f:
@@ -145,7 +146,8 @@ def test_output_loggers_configuration(
         assert 0 == len(lines)
 
     launch.logging.launch_config.log_file_name = 'some-proc-stdout.log'
-    own_log_path = launch.logging.launch_config.get_log_file_path()
+    own_log_path = launch.logging.launch_config.get_log_file_path(
+        launch.logging.launch_config.log_file_name)
     if 'own_log' in (checks['stdout'] | checks['both']):
         assert os.path.exists(own_log_path)
         assert 0 != os.stat(own_log_path).st_size
@@ -157,7 +159,8 @@ def test_output_loggers_configuration(
         assert (not os.path.exists(own_log_path) or 0 == os.stat(own_log_path).st_size)
 
     launch.logging.launch_config.log_file_name = 'some-proc-stderr.log'
-    own_log_path = launch.logging.launch_config.get_log_file_path()
+    own_log_path = launch.logging.launch_config.get_log_file_path(
+        launch.logging.launch_config.log_file_name)
     if 'own_log' in (checks['stderr'] | checks['both']):
         assert os.path.exists(own_log_path)
         assert 0 != os.stat(own_log_path).st_size
@@ -169,7 +172,8 @@ def test_output_loggers_configuration(
         assert (not os.path.exists(own_log_path) or 0 == os.stat(own_log_path).st_size)
 
     launch.logging.launch_config.log_file_name = 'some-proc.log'
-    own_log_path = launch.logging.launch_config.get_log_file_path()
+    own_log_path = launch.logging.launch_config.get_log_file_path(
+        launch.logging.launch_config.log_file_name)
     if 'own_log' in checks['both']:
         assert os.path.exists(own_log_path)
         assert 0 != os.stat(own_log_path).st_size