launch service constructor test for custom naming of log_file_name and logger_name

Signed-off-by: Tanishq Chaudhary <[email protected]>

Author: Tanishq30052002

launch/launch/launch_service.py

@@ -68,15 +68,16 @@ def __init__(
         """
         # Setup logging and debugging.
         launch.logging.launch_config.level = logging.DEBUG if debug else logging.INFO
-        if log_file_name is None:
-            log_file_name = 'launch'
+        self._log_file_name = log_file_name
+        if self._log_file_name is None:
+            self._log_file_name = 'launch'
         # Ensure the log file name ends with `.log`
-        if not log_file_name.endswith('.log'):
-            log_file_name += '.log'
-        launch.logging.launch_config.log_file_name = log_file_name
+        if not self._log_file_name.endswith('.log'):
+            self._log_file_name += '.log'
+        launch.logging.launch_config.log_file_name = self._log_file_name
         # Setup logging
-        logger_name = log_file_name.removesuffix('.log')
-        self.__logger = launch.logging.get_logger(logger_name)
+        self._logger_name = self._log_file_name.removesuffix('.log')
+        self.__logger = launch.logging.get_logger(self._logger_name)
 
         self.__debug = debug
         self.__argv = argv if argv is not None else []

launch/test/launch/test_launch_service.py

@@ -26,7 +26,18 @@
 
 def test_launch_service_constructors():
     """Test the constructors for LaunchService class."""
-    LaunchService()
+    # When no name is provided for log file
+    ls = LaunchService()
+    assert ls._log_file_name == 'launch.log'
+    assert ls._logger_name == 'launch'
+    # WHen log file name is provided without .log
+    ls = LaunchService(log_file_name='custom_logger')
+    assert ls._log_file_name == 'custom_logger.log'
+    assert ls._logger_name == 'custom_logger'
+    # When log file name is provided with .log
+    ls = LaunchService(log_file_name='custom_logger.log')
+    assert ls._log_file_name == 'custom_logger.log'
+    assert ls._logger_name == 'custom_logger'
     LaunchService(debug=True)
     LaunchService(debug=False)